Repository navigation
Conversation
…iours Unit tests only, no library change: ketama ring wrap past the last point, KetamaHashing honoring backend weights, the health counter restarting after a flip, PoolNode::remove keeping the other hot queue items, and the LRU manager's peek leaving eviction order alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1100
Tests only: five unit tests (+70 lines) in the existing test modules. No change to library code, no new dependencies.
tests::node_idx_wraps_past_last_point(pingora-ketama)selection::consistent::test::test_ketama_honors_backend_weight(pingora-load-balancing)health_check::test::test_health_counter_restarts_after_flip(pingora-load-balancing)connection::tests::test_pool_node_remove_keeps_other_hot_queue_items(pingora-pool)PoolNode::removekeeps the items queued ahead of its targeteviction::lru::test::test_peek_does_not_promote(pingora-cache)peekleaves the eviction order alone, asEvictionManager::peekdocumentsHow they were checked
On a copy at 1adcb38 (current
main):cargo fmt --all -- --check,cargo clippy --all-targets -p <crate> -- --allow=unknown-lints --deny=warningsandcargo test -p <crate>for the four crates all pass (pingora-ketama 7, pingora-load-balancing 81, pingora-pool 36 and pingora-cache 221 unit tests, including the new ones).These tests were written with Claude Code during a planted-bug run by SK @ Trenyx.